Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:disabling going back function on connectionless proof flow #1051

Conversation

CarolineLCa
Copy link
Contributor

@CarolineLCa CarolineLCa commented Dec 27, 2023

Summary of Changes

Disabling going back function on connectionless proof flow.

Expected behavior

Users should not exit this screen using the device's back button, just the home icon.

Actual behavior

Users can go back and on android it shows up a black screen, on iOS returns to the scan screen.

To fix

I added gestureEnabled for ios (didn't work on android) and Backhandler API for android, both already used in the project.
https://reactnavigation.org/docs/stack-navigator/#gestureenabled
https://reactnative.dev/docs/backhandler

Screen_Recording_20231226_170053_Aries.Bifold.mp4

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@CarolineLCa CarolineLCa requested a review from a team as a code owner December 27, 2023 18:29
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (279599d) 61.48% compared to head (d1fca64) 61.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
+ Coverage   61.48%   61.50%   +0.02%     
==========================================
  Files         170      170              
  Lines        5450     5453       +3     
  Branches     1570     1570              
==========================================
+ Hits         3351     3354       +3     
  Misses       2075     2075              
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thiagoromanos thiagoromanos self-assigned this Dec 28, 2023
Copy link
Contributor

@thiagoromanos thiagoromanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here (both Android and iOS). It's working fine.

@thiagoromanos thiagoromanos merged commit 4f26617 into openwallet-foundation:main Dec 28, 2023
7 checks passed
@CarolineLCa CarolineLCa deleted the fix/blocking-going-back-on-connectionless-proof-flow branch January 4, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants