Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scrim to common remove modal #1050

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

bryce-mcmath
Copy link
Contributor

Summary of Changes

Users were getting confused by the background of the common remove modal, thinking they could still press buttons in the header. Adding a scrim to dim the content behind the modal communicates to the users that those elements aren't accessible. Here is the before and after:
No scrim
no_scrim
With scrim
scrim

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@bryce-mcmath bryce-mcmath marked this pull request as ready for review December 18, 2023 21:27
@bryce-mcmath bryce-mcmath requested a review from a team as a code owner December 18, 2023 21:27
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9d9dc8f) 61.48% compared to head (24c7f62) 61.48%.

Files Patch % Lines
...y/core/App/components/modals/CommonRemoveModal.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1050   +/-   ##
=======================================
  Coverage   61.48%   61.48%           
=======================================
  Files         170      170           
  Lines        5450     5450           
  Branches     1570     1570           
=======================================
  Hits         3351     3351           
  Misses       2075     2075           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jleach jleach merged commit 279599d into openwallet-foundation:main Dec 18, 2023
6 of 7 checks passed
@bryce-mcmath bryce-mcmath deleted the feat/modal-scrim branch December 18, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants