Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable tours without dev mode #1047

Conversation

bryce-mcmath
Copy link
Contributor

Summary of Changes

Removes the gating behind developer mode of in-app tours. Still respects the config value for enableTours, so if you don't want to use tours you don't have to.

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@bryce-mcmath bryce-mcmath marked this pull request as ready for review December 13, 2023 00:35
@bryce-mcmath bryce-mcmath requested a review from a team as a code owner December 13, 2023 00:35
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1c5096) 61.35% compared to head (1dbad21) 61.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1047      +/-   ##
==========================================
+ Coverage   61.35%   61.48%   +0.13%     
==========================================
  Files         170      170              
  Lines        5462     5450      -12     
  Branches     1582     1570      -12     
==========================================
  Hits         3351     3351              
+ Misses       2087     2075      -12     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryce-mcmath bryce-mcmath merged commit e4c23aa into openwallet-foundation:main Dec 13, 2023
7 checks passed
@bryce-mcmath bryce-mcmath deleted the fix/enable-tours-wo-dev-mode branch December 13, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants