Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: long accessibility label #1043

Merged

Conversation

jleach
Copy link
Contributor

@jleach jleach commented Dec 7, 2023

Summary of Changes

The notifications accessibility label is overly long forcing the user to say "touch Notifications 5 notifications" to activate the tab. This reduces length and what people must speak to "Notifications (5)", now people must speak 'touch Notifications 5"

Related Issues

bcgov/bc-wallet-mobile#1640

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@jleach jleach requested a review from a team as a code owner December 7, 2023 18:41
@jleach jleach self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e4c23aa) 61.48% compared to head (e56d1f3) 61.48%.

Files Patch % Lines
packages/legacy/core/App/navigators/TabStack.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1043   +/-   ##
=======================================
  Coverage   61.48%   61.48%           
=======================================
  Files         170      170           
  Lines        5450     5450           
  Branches     1570     1570           
=======================================
  Hits         3351     3351           
  Misses       2075     2075           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jleach jleach force-pushed the fix/long-accessibility-label branch from ff359e5 to 116f8aa Compare December 9, 2023 00:33
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach force-pushed the fix/long-accessibility-label branch from 116f8aa to e56d1f3 Compare December 14, 2023 00:15
@jleach jleach merged commit e3dc111 into openwallet-foundation:main Dec 14, 2023
6 of 7 checks passed
@jleach jleach deleted the fix/long-accessibility-label branch December 14, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants