Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide attribute if value is blank #1038

Merged

Conversation

wadeking98
Copy link
Contributor

@wadeking98 wadeking98 commented Nov 30, 2023

Summary of Changes

The BC Services card has an expiry date attribute that isn't being used right now. Currently this attribute shows up as an invalid date since it is blank. This change hides all attributes from the credential offer and credential details screen which have blank attributes.

previous:

image

now:

image

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7c64f3b) 61.16% compared to head (b307f03) 61.15%.

Files Patch % Lines
.../core/App/components/record/RecordDateIntField.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
- Coverage   61.16%   61.15%   -0.01%     
==========================================
  Files         181      181              
  Lines        5528     5532       +4     
  Branches     1579     1580       +1     
==========================================
+ Hits         3381     3383       +2     
- Misses       2123     2125       +2     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jleach jleach changed the title feat: Hide attribute if value is blank feat: hide attribute if value is blank Nov 30, 2023
@wadeking98 wadeking98 merged commit b16798a into openwallet-foundation:main Nov 30, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants