Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: const override #1037

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Conversation

jleach
Copy link
Contributor

@jleach jleach commented Nov 29, 2023

Summary of Changes

Fetch configurable URL from config rather than constants.

Related Issues

n/a

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach requested a review from a team as a code owner November 29, 2023 22:40
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d6bb1b) 61.16% compared to head (1c1b3ac) 61.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1037   +/-   ##
=======================================
  Coverage   61.16%   61.16%           
=======================================
  Files         181      181           
  Lines        5528     5528           
  Branches     1579     1579           
=======================================
  Hits         3381     3381           
  Misses       2123     2123           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach self-assigned this Nov 29, 2023
@jleach jleach enabled auto-merge (squash) November 30, 2023 01:55
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jleach jleach merged commit 7c64f3b into openwallet-foundation:main Nov 30, 2023
7 checks passed
@jleach jleach deleted the feat/const-override branch November 30, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants