Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for reporting in error modal #1036

Merged

Conversation

wadeking98
Copy link
Contributor

@wadeking98 wadeking98 commented Nov 28, 2023

Summary of Changes

Added callback function for reporting on error modals. Report this problem will not display unless the callback function is passed in to the error modal
image

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@wadeking98 wadeking98 requested a review from a team as a code owner November 28, 2023 00:53
@jleach jleach force-pushed the feat-error-modal-reporting branch from 333137e to 5a12dbf Compare December 1, 2023 00:38
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b16798a) 61.15% compared to head (5a12dbf) 61.15%.

Files Patch % Lines
...ckages/legacy/core/App/components/misc/InfoBox.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1036   +/-   ##
=======================================
  Coverage   61.15%   61.15%           
=======================================
  Files         181      181           
  Lines        5532     5535    +3     
  Branches     1580     1583    +3     
=======================================
+ Hits         3383     3385    +2     
- Misses       2125     2126    +1     
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jleach jleach force-pushed the feat-error-modal-reporting branch from 5a12dbf to 96505b1 Compare December 6, 2023 17:38
@jleach jleach merged commit 4fd206d into openwallet-foundation:main Dec 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants