Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align tab styles in new scan screen #1033

Merged

Conversation

bryce-mcmath
Copy link
Contributor

Summary of Changes

This change aligns the tabs on the new scan screen with the existing main tabs, making use of the theme. I was unable to use the exact same components (from @react-navigation/bottom-tabs) because they depend on being used with actual screens, not just component views shared between one parent screen.

Old:
tabs_old

New:
tabs_new

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@bryce-mcmath bryce-mcmath marked this pull request as ready for review November 24, 2023 01:54
@bryce-mcmath bryce-mcmath requested a review from a team as a code owner November 24, 2023 01:54
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (23cd8a4) 61.30% compared to head (e562398) 61.33%.

Files Patch % Lines
packages/legacy/core/App/navigators/TabStack.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
+ Coverage   61.30%   61.33%   +0.03%     
==========================================
  Files         181      181              
  Lines        5522     5524       +2     
  Branches     1574     1575       +1     
==========================================
+ Hits         3385     3388       +3     
+ Misses       2113     2112       -1     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryce-mcmath bryce-mcmath merged commit 1015519 into openwallet-foundation:main Nov 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants