Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SharedProofData updated to use LoadingIndicator from useAnimatedComponents #1028

Conversation

CarolineLCa
Copy link
Contributor

Summary of Changes

SharedProofData updated to use LoadingIndicator from useAnimatedComponents.

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@CarolineLCa CarolineLCa requested a review from a team as a code owner November 17, 2023 21:30
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (629327b) 61.28% compared to head (d69a0b5) 61.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1028   +/-   ##
=======================================
  Coverage   61.28%   61.29%           
=======================================
  Files         181      181           
  Lines        5520     5521    +1     
  Branches     1573     1573           
=======================================
+ Hits         3383     3384    +1     
  Misses       2113     2113           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thiagoromanos thiagoromanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix. LGTM

@bryce-mcmath bryce-mcmath merged commit dd7dab2 into openwallet-foundation:main Nov 22, 2023
7 checks passed
@CarolineLCa CarolineLCa deleted the fix/-change-loadingIndicator-to-use-from-useAnimatedComponents branch December 26, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants