-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new scan workflow #1025
feat: new scan workflow #1025
Conversation
cb140ca
to
1cfac43
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 61.14% 61.28% +0.14%
==========================================
Files 181 181
Lines 5520 5520
Branches 1572 1573 +1
==========================================
+ Hits 3375 3383 +8
+ Misses 2121 2113 -8
Partials 24 24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be some missing configurable-ness, but otherwise looks good. I could be misunderstanding something
@@ -37,7 +40,7 @@ export const minute = 60000 | |||
export const hour = 3600000 | |||
|
|||
// wallet timeout of 5 minutes, 0 means the wallet never locks due to inactivity | |||
export const walletTimeout = minute * 5 | |||
export const walletTimeout = minute * 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to commit this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. Thx.
> | ||
<Stack.Screen name={Screens.Scan} component={scan} /> | ||
<Stack.Screen name={Screens.ScanHelp} component={ScanHelp} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to make this component come from config so it can be overridden? I'm assuming that's why the whereToUseWalletUrl
in ScanHelp.tsx
was to a throwaway url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now nothing but the text needs to change and I think that can be set via the translation mechanics - no? I'll give it another test and make sure it can be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok. I thought at least the URL would have to be different for each wallet project or beyond that even the general content of the ScanHelp screen would have to be different as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed. Translation work as expected although I am missing them in BC Wallet. Will fix here but that should not impact this PR as it is only for Bifold.
15efa04
to
8fd8444
Compare
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
e8c016e
to
f10cd44
Compare
Summary of Changes
New scan workflow that better allows the user to understand they cannot scan different types of barcodes nor can it scan a credit card or physical ID and add it to the wallet.
Related Issues
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.