Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new scan workflow #1025

Merged
merged 13 commits into from
Nov 22, 2023
Merged

Conversation

jleach
Copy link
Contributor

@jleach jleach commented Nov 13, 2023

Summary of Changes

New scan workflow that better allows the user to understand they cannot scan different types of barcodes nor can it scan a credit card or physical ID and add it to the wallet.

Related Issues

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@jleach jleach self-assigned this Nov 13, 2023
@jleach jleach changed the title Feat/new scan feat: new scan workflow Nov 13, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2a448d0) 61.14% compared to head (f10cd44) 61.28%.

Files Patch % Lines
...ages/legacy/core/App/components/misc/QRScanner.tsx 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
+ Coverage   61.14%   61.28%   +0.14%     
==========================================
  Files         181      181              
  Lines        5520     5520              
  Branches     1572     1573       +1     
==========================================
+ Hits         3375     3383       +8     
+ Misses       2121     2113       -8     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jleach jleach marked this pull request as ready for review November 14, 2023 15:53
@jleach jleach requested a review from a team as a code owner November 14, 2023 15:53
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be some missing configurable-ness, but otherwise looks good. I could be misunderstanding something

@@ -37,7 +40,7 @@ export const minute = 60000
export const hour = 3600000

// wallet timeout of 5 minutes, 0 means the wallet never locks due to inactivity
export const walletTimeout = minute * 5
export const walletTimeout = minute * 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to commit this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Thx.

>
<Stack.Screen name={Screens.Scan} component={scan} />
<Stack.Screen name={Screens.ScanHelp} component={ScanHelp} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to make this component come from config so it can be overridden? I'm assuming that's why the whereToUseWalletUrl in ScanHelp.tsx was to a throwaway url

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now nothing but the text needs to change and I think that can be set via the translation mechanics - no? I'll give it another test and make sure it can be.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok. I thought at least the URL would have to be different for each wallet project or beyond that even the general content of the ScanHelp screen would have to be different as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Translation work as expected although I am missing them in BC Wallet. Will fix here but that should not impact this PR as it is only for Bifold.

bryce-mcmath
bryce-mcmath previously approved these changes Nov 21, 2023
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach merged commit 96349a5 into openwallet-foundation:main Nov 22, 2023
7 checks passed
@jleach jleach deleted the feat/new-scan branch November 22, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants