Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allowing public DID connection reuse and implicit connections. #1014

Merged

Conversation

thiagoromanos
Copy link
Contributor

Summary of Changes

When receiving a invite where service is a public DID, this connection could be an implicit one (receive the same invitation multiple times) or it can reuse an existing connection which has the same public DID on invitation.
Since not all wallet implementations will want those behaviors, configurations for those were added (enableImplicitInvitations and enableReuseConnections), being disabled by default.

Related Issues

N/A.

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@thiagoromanos thiagoromanos requested a review from a team as a code owner October 27, 2023 19:28
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1014 (65f9235) into main (374b616) will decrease coverage by 0.10%.
The diff coverage is 22.72%.

@@            Coverage Diff             @@
##             main    #1014      +/-   ##
==========================================
- Coverage   61.03%   60.94%   -0.10%     
==========================================
  Files         180      180              
  Lines        5431     5446      +15     
  Branches     1552     1559       +7     
==========================================
+ Hits         3315     3319       +4     
- Misses       2092     2103      +11     
  Partials       24       24              
Files Coverage Δ
...ackages/legacy/core/App/contexts/configuration.tsx 100.00% <ø> (ø)
packages/legacy/core/App/navigators/RootStack.tsx 0.83% <0.00%> (ø)
packages/legacy/core/App/navigators/TabStack.tsx 2.38% <0.00%> (ø)
packages/legacy/core/App/screens/Scan.tsx 46.66% <57.14%> (+1.73%) ⬆️
packages/legacy/core/App/utils/helpers.ts 57.48% <9.09%> (-1.15%) ⬇️

@jleach jleach force-pushed the implicit-connections branch from 4eca190 to a95c1c5 Compare October 31, 2023 23:15
@jleach jleach merged commit 4ceef79 into openwallet-foundation:main Nov 1, 2023
5 of 7 checks passed
@thiagoromanos thiagoromanos deleted the implicit-connections branch November 1, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants