Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing cred proof grouping #1012

Merged

Conversation

wadeking98
Copy link
Contributor

@wadeking98 wadeking98 commented Oct 26, 2023

Summary of Changes

Previously if a credential was missing from a proof request, it wouldn't be displayed properly in the proof request screen, predicates and attributes would be split so that it appears that they're coming from two different credentials. I've added functionality to properly group missing credentials. Additionally I fixed some UI bugs that present themselves when all credenbtials in a proof don't exist in the wallet

Related Issues

#1011

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@wadeking98 wadeking98 requested a review from a team as a code owner October 26, 2023 21:21
packages/legacy/core/App/screens/ProofRequest.tsx Outdated Show resolved Hide resolved
packages/legacy/core/App/screens/ProofRequest.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1012 (07be715) into main (ecea2b9) will increase coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
+ Coverage   60.79%   60.81%   +0.02%     
==========================================
  Files         179      179              
  Lines        5387     5390       +3     
  Branches     1532     1534       +2     
==========================================
+ Hits         3275     3278       +3     
  Misses       2087     2087              
  Partials       25       25              
Files Coverage Δ
packages/legacy/core/App/screens/ProofRequest.tsx 64.45% <100.00%> (+0.51%) ⬆️
packages/legacy/core/App/utils/helpers.ts 58.62% <33.33%> (ø)

Signed-off-by: wadeking98 <[email protected]>
@wadeking98 wadeking98 force-pushed the fix-missing-cred-proof-grouping branch from da52e9f to 07be715 Compare October 26, 2023 21:31
@wadeking98 wadeking98 requested a review from jleach October 26, 2023 21:31
@jleach jleach merged commit 0e2e102 into openwallet-foundation:main Oct 26, 2023
6 of 7 checks passed
@bryce-mcmath bryce-mcmath changed the title Fix missing cred proof grouping fix: missing cred proof grouping Oct 26, 2023
thiagoromanos pushed a commit to thiagoromanos/bifold-wallet-romano that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants