Skip to content

Commit

Permalink
chore: upgrade node version to 18.18 (#1024)
Browse files Browse the repository at this point in the history
Signed-off-by: Bryce McMath <[email protected]>
  • Loading branch information
bryce-mcmath authored Nov 11, 2023
1 parent bf5cf8a commit 046df75
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/actions/setup-node/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ inputs:
node-version:
description: Node version to use
required: false
default: '16.15.0'
default: '18.18.2'

runs:
using: composite
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ jobs:
steps:
- uses: actions/checkout@v3

- uses: actions/setup-python@v4
with:
python-version: '3.11'

- name: Setup NodeJS
uses: ./.github/actions/setup-node

Expand Down Expand Up @@ -103,6 +107,10 @@ jobs:
steps:
- uses: actions/checkout@v3

- uses: actions/setup-python@v4
with:
python-version: '3.11'

- name: Setup NodeJS
uses: ./.github/actions/setup-node

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ jobs:
with:
fetch-depth: 0

- uses: actions/setup-python@v4
with:
python-version: '3.11'

- name: Setup NodeJS
uses: ./.github/actions/setup-node

Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ jobs:
- name: Checkout aries-mobile-agent-react-native
uses: actions/checkout@v3

- uses: actions/setup-python@v4
with:
python-version: '3.11'

- name: Setup NodeJS
uses: ./.github/actions/setup-node

Expand All @@ -41,6 +45,10 @@ jobs:
- name: Checkout aries-mobile-agent-react-native
uses: actions/checkout@v3

- uses: actions/setup-python@v4
with:
python-version: '3.11'

- name: Setup NodeJS
uses: ./.github/actions/setup-node

Expand Down
2 changes: 1 addition & 1 deletion DEVELOPER.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ This is a [yarn](https://yarnpkg.com) based project, not [npm](https://www.npmjs

```sh
npm install -g yarn
nvm install 16.15
nvm install 18.18
```

This project will need to run on an iOS device or Android device or emulator. While it is recommended to test your software on both, especially if you're contributing back to the project, for demonstration purposes you can choose one or the other.
Expand Down
4 changes: 2 additions & 2 deletions DEVELOPER_MACOS_arm64.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@
```
1. Install Node
```sh
nvm install 16.15.0
nvm install 18.18.2
```
Activate node version by adding the following to your `~/.zprofile`
```sh
source $(brew --prefix nvm)/nvm.sh
nvm use 16.15.0
nvm use 18.18.2
```
1. Install Yarn
```sh
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"typescript": "^5.0.4"
},
"engines": {
"node": ">=16.15.0 <18.0.0",
"node": ">=18.18.2 <20.0.0",
"yarn": "^3.3.1"
},
"resolutions": {
Expand Down

0 comments on commit 046df75

Please sign in to comment.