Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snippets] Add debug caps for dumping snippets parameters #28378

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[Snippets] Add debug caps for dumping snippets parameters #28378

wants to merge 8 commits into from
+478 −52

Conversation

aobolensk
Copy link
Contributor

Details:

  • Add infrastructure to dump snippets parameters using OV_SNIPPETS_DUMP_PARAMS environment variable
  • Enable caps for brgemm snippet

Tickets:

  • 137302

@aobolensk aobolensk requested a review from v-Golubev January 10, 2025 15:06
@aobolensk aobolensk requested a review from a team as a code owner January 10, 2025 15:06
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Jan 10, 2025
@aobolensk aobolensk requested a review from a team as a code owner January 10, 2025 15:50
@aobolensk aobolensk requested review from tsavina and removed request for a team January 10, 2025 15:50
@github-actions github-actions bot added the category: docs OpenVINO documentation label Jan 10, 2025
@aobolensk aobolensk requested a review from v-Golubev January 13, 2025 13:37
@aobolensk aobolensk requested a review from a team as a code owner January 14, 2025 13:51
@aobolensk aobolensk force-pushed the brgemm-debug-caps branch 2 times, most recently from 4229be8 to 1fe9e26 Compare January 14, 2025 18:13
@aobolensk aobolensk requested a review from v-Golubev January 15, 2025 08:25
v-Golubev
v-Golubev reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@v-Golubev v-Golubev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be also useful to dump Subgraph's name as well. Let's discuss possible options offline

src/common/snippets/include/snippets/lowered/pass/brgemm_debug_params.hpp Outdated Show resolved Hide resolved
src/common/snippets/include/snippets/lowered/pass/brgemm_debug_params.hpp Outdated Show resolved Hide resolved
src/common/snippets/include/snippets/lowered/pass/brgemm_debug_params.hpp Outdated Show resolved Hide resolved
src/common/snippets/include/snippets/lowered/pass/brgemm_debug_params.hpp Outdated Show resolved Hide resolved
src/common/snippets/include/snippets/lowered/pass/brgemm_debug_params.hpp Outdated Show resolved Hide resolved
src/common/snippets/include/snippets/lowered/pass/brgemm_debug_params.hpp Outdated Show resolved Hide resolved
src/common/snippets/include/snippets/lowered/pass/brgemm_debug_params.hpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/nodes/subgraph.cpp Show resolved Hide resolved
@aobolensk
Copy link
Contributor Author

It can be also useful to dump Subgraph's name as well. Let's discuss possible options offline

Done

v-Golubev
v-Golubev approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@v-Golubev v-Golubev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aobolensk aobolensk force-pushed the brgemm-debug-caps branch 3 times, most recently from a75589b to cb4be59 Compare January 17, 2025 11:04
@github-actions github-actions bot removed category: GPU OpenVINO GPU plugin category: build OpenVINO cmake script / infra category: Python API OpenVINO Python bindings category: CI OpenVINO public CI category: dependency_changes Pull requests that update a dependency file category: PDPD FE OpenVINO PaddlePaddle FrontEnd category: TF FE OpenVINO TensorFlow FrontEnd category: packaging OpenVINO packaging / distribution github_actions Pull requests that update GitHub Actions code category: TFL FE OpenVINO TensorFlow Lite FrontEnd no-match-files category: NPU OpenVINO NPU plugin labels Jan 28, 2025
@aobolensk aobolensk removed request for tsavina, a team, akuporos and AlexKoff88 January 28, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-Golubev v-Golubev v-Golubev approved these changes

@a-sidorova a-sidorova a-sidorova approved these changes

@IvanNovoselov IvanNovoselov Awaiting requested review from IvanNovoselov

Assignees

@IvanNovoselov IvanNovoselov

Labels
category: CPU OpenVINO CPU plugin category: docs OpenVINO documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aobolensk @a-sidorova @v-Golubev @IvanNovoselov