Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sampling to vlm pipeline by Sampler #950

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Add sampling to vlm pipeline by Sampler #950

merged 2 commits into from
Oct 17, 2024

Conversation

sbalandi
Copy link
Contributor

@sbalandi sbalandi commented Oct 11, 2024 •
edited by andrei-kochin
Loading

CVS-152890

@sbalandi sbalandi marked this pull request as ready for review October 11, 2024 19:19
@sbalandi sbalandi mentioned this pull request Oct 11, 2024
Closed
@sbalandi sbalandi requested review from iefode, Wovchena and ilya-lavrenov and removed request for iefode and Wovchena October 11, 2024 19:58
Wovchena
Wovchena requested changes Oct 14, 2024
View reviewed changes
samples/cpp/visual_language_chat/visual_language_chat.cpp Outdated Show resolved Hide resolved
samples/cpp/visual_language_chat/visual_language_chat.cpp Outdated Show resolved Hide resolved
src/cpp/src/vlm_pipeline.cpp Outdated Show resolved Hide resolved
src/cpp/src/vlm_pipeline.cpp Outdated Show resolved Hide resolved
src/cpp/src/vlm_pipeline.cpp Outdated Show resolved Hide resolved
ilya-lavrenov
ilya-lavrenov reviewed Oct 14, 2024
View reviewed changes
src/cpp/include/openvino/genai/generation_config.hpp Outdated Show resolved Hide resolved
samples/cpp/visual_language_chat/visual_language_chat.cpp Outdated Show resolved Hide resolved
samples/cpp/visual_language_chat/visual_language_chat.cpp Outdated Show resolved Hide resolved
samples/cpp/visual_language_chat/visual_language_chat.cpp Outdated Show resolved Hide resolved
src/cpp/src/vlm_pipeline.cpp Outdated Show resolved Hide resolved
src/cpp/src/vlm_pipeline.cpp Outdated Show resolved Hide resolved
src/cpp/src/vlm_pipeline.cpp Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov added this to the 2024.5 milestone Oct 14, 2024
@ilya-lavrenov ilya-lavrenov added category: visual language Visual language pipeline category: sampling Sampling / Decoding algorithms labels Oct 15, 2024
Wovchena
Wovchena previously requested changes Oct 15, 2024
View reviewed changes
samples/cpp/visual_language_chat/visual_language_chat.cpp Outdated Show resolved Hide resolved
samples/cpp/visual_language_chat/visual_language_chat.cpp Outdated Show resolved Hide resolved
src/cpp/src/visual_language/pipeline.cpp Outdated Show resolved Hide resolved
src/cpp/src/visual_language/pipeline.cpp Outdated Show resolved Hide resolved
@sbalandi sbalandi force-pushed the miniCPM-sampler branch 2 times, most recently from 6ff3055 to c3fe8d4 Compare October 16, 2024 10:45
@github-actions github-actions bot added category: GHA CI based on Github actions category: samples GenAI samples labels Oct 16, 2024
ilya-lavrenov
ilya-lavrenov approved these changes Oct 17, 2024
View reviewed changes
samples/cpp/visual_language_chat/visual_language_chat.cpp Outdated Show resolved Hide resolved
src/cpp/src/visual_language/pipeline.cpp Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov dismissed Wovchena’s stale review October 17, 2024 06:34

please, review once again

@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Oct 17, 2024
@Wovchena Wovchena mentioned this pull request Oct 17, 2024
Merged
Merged via the queue into openvinotoolkit:master with commit 90b1ab1 Oct 17, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wovchena Wovchena Wovchena approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@iefode iefode Awaiting requested review from iefode

Assignees

@ilya-lavrenov ilya-lavrenov

@Wovchena Wovchena

Labels
category: GHA CI based on Github actions category: samples GenAI samples category: sampling Sampling / Decoding algorithms category: visual language Visual language pipeline Code Freeze
Projects
None yet
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.
3 participants
@sbalandi @ilya-lavrenov @Wovchena