Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CB] SpeculativeDecoding impl C++ #907

Merged
merged 48 commits into from
Oct 18, 2024

Conversation

iefode
Copy link
Contributor

@iefode iefode commented Sep 30, 2024

@ilya-lavrenov ilya-lavrenov self-assigned this Sep 30, 2024
@iefode iefode marked this pull request as draft October 1, 2024 07:29
@iefode iefode marked this pull request as ready for review October 8, 2024 10:02
@iefode
Copy link
Contributor Author

iefode commented Oct 8, 2024

@ilya-lavrenov Please take a look

@ilya-lavrenov ilya-lavrenov added this to the 2024.5 milestone Oct 10, 2024
@ilya-lavrenov
Copy link
Contributor

Please, adjust sample test as well https://github.com/openvinotoolkit/openvino.genai/blob/master/.github/workflows/causal_lm_cpp.yml#L396-L437 once you change speculative decoding sample

@github-actions github-actions bot added category: continuous batching Continuous batching category: LLM LLM pipeline (stateful, static) category: sampling Sampling / Decoding algorithms category: GHA CI based on Github actions category: cmake / build Cmake scripts category: samples GenAI samples category: GenAI C++ API Changes in GenAI C++ public headers labels Oct 16, 2024
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, good job!
Suggest sample simplification as a separate change.

@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Oct 17, 2024
@AlexKoff88 AlexKoff88 removed this pull request from the merge queue due to a manual request Oct 17, 2024
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 17, 2024
@iefode iefode added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Oct 18, 2024
Merged via the queue into openvinotoolkit:master with commit 2378ab0 Oct 18, 2024
49 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Oct 18, 2024
Spin off of #907.
Merge after head PR

---------

Co-authored-by: Ilya Lavrenov <[email protected]>
ScottZhang812 pushed a commit to ScottZhang812/_openvino.genai that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: cmake / build Cmake scripts category: continuous batching Continuous batching category: GenAI C++ API Changes in GenAI C++ public headers category: GHA CI based on Github actions category: LLM LLM pipeline (stateful, static) category: samples GenAI samples category: sampling Sampling / Decoding algorithms category: speculative decoding Speculative decoding Code Freeze
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants