-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi prompt support for beam search #349
Merged
ilya-lavrenov
merged 23 commits into
openvinotoolkit:master
from
as-suvorov:asuvorov/multy-prompt-beam-search
Apr 11, 2024
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
558af6a
Add multi prompt support
as-suvorov 29ce68a
Add test
as-suvorov 3da2ce2
Fix tokenizer model name
as-suvorov df9afd2
Update tokenizers
as-suvorov 5ef19f2
Update OV version in tests
as-suvorov cf6e7b8
Update OV version in tests
as-suvorov 5d455b6
Update OV versions
as-suvorov 493ab01
Update tokenizers
as-suvorov 0e90346
Merge remote-tracking branch 'upstream/master' into asuvorov/multy-pr…
as-suvorov c86f607
Add quotes
as-suvorov 62ba58a
Update tokenizers
as-suvorov 0cbcd91
Update ov version
as-suvorov 92f03a3
Update tokenizers
as-suvorov fa95745
Update tokenizers
as-suvorov 0c54697
Update ov for llm bench
as-suvorov ca994ad
Install ov-nightly with pip for conda
as-suvorov d782b99
Use tokenizers 2024.1 branch
as-suvorov a321efb
Revert version changes
as-suvorov c204182
Add wa for tokenizer attention_mask
as-suvorov 93644d1
Add quotes
as-suvorov fe21df5
Handle finished beams
as-suvorov acab030
Merge branch 'master' into asuvorov/multy-prompt-beam-search
as-suvorov 9cc9ca4
Update tokenizers
as-suvorov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
side note:
currently, we use batched inference with tokenizers and it creates attention mask for us, which we need to "parse" later. Maybe, alternatively, we could tokenize prompt one by one and it will return us raw (unpadded) data, which we can use more optimally to fill position_ids, etc.
I'm not sure which solution is more optimal, so, let's stick to current one, because it's already implemented.