Allow SIRI's StopPointRef to refer to a NeTEx scheduled stop point #6397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Even though the various documents on SIRI and NeTEx are quite unclear, even contradictory what exactly an EstimatedCall's
StopPointRef
should refer to, all the experts agree that it a scheduled stop point is probably a better target.We discussed this at length at https://public.3.basecamp.com/p/TcEEP5WrNZJPBxrJU9GAjint
For this reason, this adds support for SIRI to refer to scheduled stop point.
Issue
#6340
Unit tests
I added some for the EntityResolver and the TimetableRepository.
Documentation
I didn't want to duplicate the documentation for this in several places so I opted to documented it in the innermost layer (TimetableRepository) and link to it in other places.
Bumping the serialization version id
✔️
cc @rcavaliere