Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci workflow for validating schema changes #6396

Open
wants to merge 1 commit into
base: dev-2.x
Choose a base branch
from

Conversation

optionsome
Copy link
Member

@optionsome optionsome commented Jan 17, 2025

Summary

Adds CI workflow that uses schema inspector to validate that there are no breaking schema changes and to list changes.

Issue

This was shortly discussed in a dev meeting this week

Unit tests

No

Documentation

No

Changelog

Skipped

@optionsome optionsome requested a review from a team as a code owner January 17, 2025 14:11
@optionsome
Copy link
Member Author

@leonardehrenfried perhaps we need to use a token? Seems like giving all permissions didn't fix the issue.

@leonardehrenfried
Copy link
Member

I'm sorry but I don't have a clue.

@optionsome optionsome force-pushed the ci-schema-validation branch from 6346e13 to 7788f1d Compare January 17, 2025 14:33
@optionsome
Copy link
Member Author

Maybe we need to use pull_request_target instead of pull_request for some reason but it does have some security concerns that I haven't fully looked into yet and action doesn't seem to run yet (perhaps the pr needs to be merged first).

@optionsome optionsome force-pushed the ci-schema-validation branch from 56c93b8 to 01cd2ed Compare January 17, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants