forked from hashicorp/terraform-provider-aws
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork Sync: Update from parent repository #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
% make testacc TESTARGS='-run=TestAccDataSyncLocationFSxONTAPFileSystem_basic\|TestAccDataSyncLocationFSxONTAPFileSystem_smb' PKG=datasync ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run=TestAccDataSyncLocationFSxONTAPFileSystem_basic\|TestAccDataSyncLocationFSxONTAPFileSystem_smb -timeout 360m === RUN TestAccDataSyncLocationFSxONTAPFileSystem_basic === PAUSE TestAccDataSyncLocationFSxONTAPFileSystem_basic === RUN TestAccDataSyncLocationFSxONTAPFileSystem_smb === PAUSE TestAccDataSyncLocationFSxONTAPFileSystem_smb === CONT TestAccDataSyncLocationFSxONTAPFileSystem_basic === CONT TestAccDataSyncLocationFSxONTAPFileSystem_smb location_fsx_ontap_file_system_test.go:103: Step 1/2 error: Error running apply: exit status 1 Error: creating DataSync Location FSx for NetApp ONTAP File System: InvalidParameter: 2 validation error(s) found. - missing required field, CreateLocationFsxOntapInput.Protocol.SMB.Password. - missing required field, CreateLocationFsxOntapInput.Protocol.SMB.User. with aws_datasync_location_fsx_ontap_file_system.test, on terraform_plugin_test.tf line 72, in resource "aws_datasync_location_fsx_ontap_file_system" "test": 72: resource "aws_datasync_location_fsx_ontap_file_system" "test" { --- PASS: TestAccDataSyncLocationFSxONTAPFileSystem_basic (2365.08s) --- FAIL: TestAccDataSyncLocationFSxONTAPFileSystem_smb (2408.72s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/datasync 2414.085s FAIL make: *** [testacc] Error 1
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccDataSyncLocationFSxONTAPFileSystem_smb' PKG=datasync ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run=TestAccDataSyncLocationFSxONTAPFileSystem_smb -timeout 720m === RUN TestAccDataSyncLocationFSxONTAPFileSystem_smb === PAUSE TestAccDataSyncLocationFSxONTAPFileSystem_smb === CONT TestAccDataSyncLocationFSxONTAPFileSystem_smb location_fsx_ontap_file_system_test.go:106: Step 1/2 error: Check failed: 1 error occurred: * Check 8/9 error: aws_datasync_location_fsx_ontap_file_system.test: Attribute 'protocol.0.smb.0.password' expected "MyPassw0rd1", got "" --- FAIL: TestAccDataSyncLocationFSxONTAPFileSystem_smb (2705.00s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/datasync 2710.293s FAIL make: *** [testacc] Error 1
…ds in smb" This reverts commit 165cc9d.
…turned from the API, so propagate from configuration.
…ssing_fields aws_datasync_location_fsx_ontap_file_system: fix missing fields in smb
…loop cloudfront/distribution: Sweeper infinite loop
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
Improvements or additions to documentation
provider
tests
sweeper
service/cloudfront
service/datasync
size/L
labels
Sep 28, 2023
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
documentation
Improvements or additions to documentation
provider
service/cloudfront
service/datasync
size/L
sweeper
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.