Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork Sync: Update from parent repository #32

Merged
merged 14 commits into from
Sep 28, 2023
Merged

Conversation

mbialon
Copy link

@mbialon mbialon commented Sep 28, 2023

No description provided.

acwwat and others added 14 commits September 27, 2023 02:33
% make testacc TESTARGS='-run=TestAccDataSyncLocationFSxONTAPFileSystem_basic\|TestAccDataSyncLocationFSxONTAPFileSystem_smb' PKG=datasync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20  -run=TestAccDataSyncLocationFSxONTAPFileSystem_basic\|TestAccDataSyncLocationFSxONTAPFileSystem_smb -timeout 360m
=== RUN   TestAccDataSyncLocationFSxONTAPFileSystem_basic
=== PAUSE TestAccDataSyncLocationFSxONTAPFileSystem_basic
=== RUN   TestAccDataSyncLocationFSxONTAPFileSystem_smb
=== PAUSE TestAccDataSyncLocationFSxONTAPFileSystem_smb
=== CONT  TestAccDataSyncLocationFSxONTAPFileSystem_basic
=== CONT  TestAccDataSyncLocationFSxONTAPFileSystem_smb
    location_fsx_ontap_file_system_test.go:103: Step 1/2 error: Error running apply: exit status 1

        Error: creating DataSync Location FSx for NetApp ONTAP File System: InvalidParameter: 2 validation error(s) found.
        - missing required field, CreateLocationFsxOntapInput.Protocol.SMB.Password.
        - missing required field, CreateLocationFsxOntapInput.Protocol.SMB.User.

          with aws_datasync_location_fsx_ontap_file_system.test,
          on terraform_plugin_test.tf line 72, in resource "aws_datasync_location_fsx_ontap_file_system" "test":
          72: resource "aws_datasync_location_fsx_ontap_file_system" "test" {

--- PASS: TestAccDataSyncLocationFSxONTAPFileSystem_basic (2365.08s)
--- FAIL: TestAccDataSyncLocationFSxONTAPFileSystem_smb (2408.72s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	2414.085s
FAIL
make: *** [testacc] Error 1
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccDataSyncLocationFSxONTAPFileSystem_smb' PKG=datasync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20  -run=TestAccDataSyncLocationFSxONTAPFileSystem_smb -timeout 720m
=== RUN   TestAccDataSyncLocationFSxONTAPFileSystem_smb
=== PAUSE TestAccDataSyncLocationFSxONTAPFileSystem_smb
=== CONT  TestAccDataSyncLocationFSxONTAPFileSystem_smb
    location_fsx_ontap_file_system_test.go:106: Step 1/2 error: Check failed: 1 error occurred:
        	* Check 8/9 error: aws_datasync_location_fsx_ontap_file_system.test: Attribute 'protocol.0.smb.0.password' expected "MyPassw0rd1", got ""

--- FAIL: TestAccDataSyncLocationFSxONTAPFileSystem_smb (2705.00s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	2710.293s
FAIL
make: *** [testacc] Error 1
…turned from the API, so propagate from configuration.
…ssing_fields

aws_datasync_location_fsx_ontap_file_system: fix missing fields in smb
…loop

cloudfront/distribution: Sweeper infinite loop
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@mbialon mbialon merged commit 6337c2c into opentofu:main Sep 28, 2023
21 of 30 checks passed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants