Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GitHub's admonitions #195

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

damianstasik
Copy link
Collaborator

@damianstasik damianstasik commented Sep 6, 2024

Fixes #192

This is a short-term solution since these components shouldn't be responsible for rendering admonitions. It should be handled in a remark/rehype plugin, but we can do later.

TODO

  • Style summary/detail
  • Make it look good

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • My contribution is compatible with the MPL-2.0 license and I have provided a DCO sign-off on all my commits.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.

Copy link

cloudflare-workers-and-pages bot commented Sep 6, 2024

Deploying registry-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6edf599
Status: ✅  Deploy successful!
Preview URL: https://377c568e.registry-ui-dxi.pages.dev
Branch Preview URL: https://support-gh-admonitions.registry-ui-dxi.pages.dev

View logs

@damianstasik damianstasik force-pushed the support-gh-admonitions branch from 113a716 to c16ef8e Compare September 6, 2024 19:07
Signed-off-by: Damian Stasik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github-flavoured markdown admonitions are not rendered.
1 participant