Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow changing right padding #133

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

damianstasik
Copy link
Collaborator

@damianstasik damianstasik commented Sep 3, 2024

When you open the search bar the library we use (Headless UI) sets right padding to offset the lack of scrollbar. Since we enforce stable scrollbar gutters we don't need the padding, otherwise we get doubled space.

Before After
beforescroll.mov
afterscroll.mov

Signed-off-by: Damian Stasik <[email protected]>
@damianstasik damianstasik force-pushed the disallow-changing-right-padding branch from 2adbd6b to 9cbfb72 Compare September 3, 2024 14:08
Copy link

cloudflare-workers-and-pages bot commented Sep 3, 2024

Deploying registry-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9cbfb72
Status: ✅  Deploy successful!
Preview URL: https://12b4fcf9.registry-ui-dxi.pages.dev
Branch Preview URL: https://disallow-changing-right-padd.registry-ui-dxi.pages.dev

View logs

@damianstasik damianstasik marked this pull request as ready for review September 3, 2024 14:08
@damianstasik damianstasik merged commit bd151d6 into main Sep 3, 2024
4 checks passed
@damianstasik damianstasik deleted the disallow-changing-right-padding branch September 3, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants