Clone cached response before applying CORS headers #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying registry-ui with
|
| Latest commit: |
6c6580e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d33aeba.registry-ui-dxi.pages.dev |
| Branch Preview URL: | https://clone-cached-response-before.registry-ui-dxi.pages.dev |
Signed-off-by: Damian Stasik <[email protected]>
damianstasik
force-pushed
the
clone-cached-response-before-applying-cors
branch
from
1fae782 to
bdaddb0
Compare
Signed-off-by: Damian Stasik <[email protected]>
Yantrio
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response returned from the cache is immutable, so attempting to attach additional headers throws an error. To resolve this, we need to create a fresh response based on the cached one and then set the CORS headers on it.