Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle module schema errors #106

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Handle module schema errors #106

merged 5 commits into from
Sep 2, 2024

Conversation

damianstasik
Copy link
Collaborator

@damianstasik damianstasik commented Aug 28, 2024

Closes #101

  • Block links in the menu on the left side
  • Show a warning with info that no schema is available
  • Redirect back to main page from disabled subpages

Screenshot 2024-08-30 at 17 20 50

Preview:
https://handle-module-schema-errors.registry-ui-dxi.pages.dev/module/env0/template/env0/v0.0.8

Copy link

cloudflare-workers-and-pages bot commented Aug 28, 2024

Deploying registry-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 216c967
Status: ✅  Deploy successful!
Preview URL: https://1ec87e35.registry-ui-dxi.pages.dev
Branch Preview URL: https://handle-module-schema-errors.registry-ui-dxi.pages.dev

View logs

@damianstasik damianstasik force-pushed the handle-module-schema-errors branch from 276decb to 89cb833 Compare August 30, 2024 14:07
@damianstasik damianstasik marked this pull request as ready for review August 30, 2024 15:26
Signed-off-by: Damian Stasik <[email protected]>
Signed-off-by: Damian Stasik <[email protected]>
Signed-off-by: Damian Stasik <[email protected]>
@damianstasik damianstasik force-pushed the handle-module-schema-errors branch from ded9cd0 to 216c967 Compare September 2, 2024 14:02
@Yantrio Yantrio merged commit 1856c34 into main Sep 2, 2024
4 checks passed
@Yantrio Yantrio deleted the handle-module-schema-errors branch September 2, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend should display module parsing error
2 participants