Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in color of text when we hover in light mode #278

Merged
10 commits merged into from
Mar 20, 2024

Conversation

namgyalangmo
Copy link
Contributor

@namgyalangmo namgyalangmo commented Mar 12, 2024

Description

resolves #177

Changes

  • I adjusted the logo and icons to use text-brand-500 and added a drop shadow as per the discussion in comments.

  • I replaced the existing text-brand-700 with text-brand-650 to better align with the color scheme in light mode.
    note: text-brand-650 was used instead of text-brand 500 as text-brand-500 got washed out on white background despite the use of drop shadows and text-outlines when viewing texts with small font.

  • It's worth noting that text-brand-650 is slightly darker than the standard text-brand-500, but it blends in seamlessly unlike text-brand-700, ensuring consistency across the design.

note:

Screenshots (if appropriate):

Final look:
logo:
Screenshot 2024-03-12 at 5 44 50 PM
header:
Screenshot 2024-03-14 at 10 57 14 AM
Icons:
Screenshot 2024-03-14 at 10 59 28 AM

footer:
Screenshot 2024-03-12 at 5 46 15 PM

@ghost
Copy link

ghost commented Mar 12, 2024

Hey @namgyalangmo thank you for your work. We are a bit under water preparing for the 1.7.0-alpha1 release, but ping me on this issue if you don't get any reviews by next week please.

@namgyalangmo
Copy link
Contributor Author

@janosdebugs gentle reminder.

@ghost
Copy link

ghost commented Mar 19, 2024

Hi @namgyalangmo thank you for poking me. I've looked at it and there are a few issues.

  1. The "The Linux Foundation Projects" logo on the front page seems to also be affected which suggests it is clickable, but it is not:

image

  1. The menu link text still has a relatively low contrast when hovered, I think the shadow might help here too.
  2. The logo has a weird 2-phase hover. The yellow logo appears when hovering near the logo, but the shadow only appears when your cursor is directly on the logo. It seems like the hover effect is on the wrong element.

@namgyalangmo
Copy link
Contributor Author

will look into it and make the necessary changes.

@namgyalangmo
Copy link
Contributor Author

namgyalangmo commented Mar 19, 2024

I have addressed points 1 and 3 as requested. Regarding point 2, I attempted to add a shadow to the text and also tried giving an outline to text. However, due to the small font size, it appeared blurry to me. Instead, I opted to use a darker shade of yellow. Please let me know your thoughts on this approach!

menu link text with shadow
shadow
menu link text with alternate shadow
shadow pt2

Current preference
Screenshot 2024-03-20 at 2 21 21 AM

Signed-off-by: namgyalangmo <[email protected]>
@ghost ghost self-requested a review March 20, 2024 05:54
@ghost
Copy link

ghost commented Mar 20, 2024

@namgyalangmo I've tested it and there is still a very low contrast on my monitor. I tried the following setting, which seems to work much better:

text-shadow: -1px -1px 0 rgba(0,0,0,0.25), 1px -1px 0 rgba(0,0,0,0.25), -1px 1px 0 rgba(0,0,0,0.25), 1px 1px 0 rgba(0,0,0,0.25)

image

I'm open to any solution as long as the contrast is high enough for people to read it.

Signed-off-by: namgyalangmo <[email protected]>
@namgyalangmo
Copy link
Contributor Author

I have added the suggested shadow, please have a look @janosdebugs .

Signed-off-by: namgyalangmo <[email protected]>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @namgyalangmo !

@ghost ghost merged commit a2058bf into opentofu:main Mar 20, 2024
1 of 2 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Colour shade on hovering at all footer items at light mode needs to be improved
1 participant