-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change in color of text when we hover in light mode #278
Conversation
Signed-off-by: namgyalangmo <[email protected]>
Signed-off-by: namgyalangmo <[email protected]>
Hey @namgyalangmo thank you for your work. We are a bit under water preparing for the 1.7.0-alpha1 release, but ping me on this issue if you don't get any reviews by next week please. |
@janosdebugs gentle reminder. |
Hi @namgyalangmo thank you for poking me. I've looked at it and there are a few issues.
|
will look into it and make the necessary changes. |
Signed-off-by: namgyalangmo <[email protected]>
…nto color-hover
Signed-off-by: namgyalangmo <[email protected]>
Signed-off-by: namgyalangmo <[email protected]>
@namgyalangmo I've tested it and there is still a very low contrast on my monitor. I tried the following setting, which seems to work much better:
I'm open to any solution as long as the contrast is high enough for people to read it. |
Signed-off-by: namgyalangmo <[email protected]>
I have added the suggested shadow, please have a look @janosdebugs . |
Signed-off-by: namgyalangmo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you @namgyalangmo !
Description
resolves #177
Changes
I adjusted the logo and icons to use text-brand-500 and added a drop shadow as per the discussion in comments.
I replaced the existing text-brand-700 with text-brand-650 to better align with the color scheme in light mode.
note: text-brand-650 was used instead of text-brand 500 as text-brand-500 got washed out on white background despite the use of drop shadows and text-outlines when viewing texts with small font.
It's worth noting that text-brand-650 is slightly darker than the standard text-brand-500, but it blends in seamlessly unlike text-brand-700, ensuring consistency across the design.
note:
Screenshots (if appropriate):
Final look:
logo:
header:
Icons:
footer: