-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: changed the staled twitter icon #236
Conversation
5ca0eaa
to
3b021ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to retract my approval, but I believe the word "twitter" should also be changed everywhere on the website accordingly, including in the configuration.
FWIW opentofu/opentofu#1028 is related. |
Signed-off-by: Dev Parikh <[email protected]>
Signed-off-by: Dev Parikh <[email protected]>
3e8bc16
to
0987d10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, the changes look good, but there seems to be some unrelated stuff in there. Could you please remove those?
@@ -15171,6 +15180,11 @@ | |||
"url": "https://github.com/sponsors/ljharb" | |||
} | |||
}, | |||
"node_modules/which/node_modules/isexe": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be some unrelated changes here. Could you please remove these?
Thank you for your work, this is now resolved. Closing in favor of #267 |
Description
Replaced the old twitter icon to new twitter icon
Motivation and Context
The motive was to change the old twitter icon to new one
Screenshots (if appropriate):
Types of changes
Checklist: