Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed the staled twitter icon #236

Closed
wants to merge 2 commits into from

Conversation

Dev79844
Copy link

Description

Replaced the old twitter icon to new twitter icon

Motivation and Context

The motive was to change the old twitter icon to new one

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@Dev79844 Dev79844 force-pushed the staled-twitter-icon branch from 5ca0eaa to 3b021ff Compare December 26, 2023 19:00
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!
image

@ghost
Copy link

ghost commented Dec 27, 2023

Side note, the mobile menu still says "Twitter"
image

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to retract my approval, but I believe the word "twitter" should also be changed everywhere on the website accordingly, including in the configuration.

@ebel
Copy link

ebel commented Dec 27, 2023

FWIW opentofu/opentofu#1028 is related.

@Dev79844 Dev79844 force-pushed the staled-twitter-icon branch from 3e8bc16 to 0987d10 Compare January 3, 2024 15:45
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, the changes look good, but there seems to be some unrelated stuff in there. Could you please remove those?

@@ -15171,6 +15180,11 @@
"url": "https://github.com/sponsors/ljharb"
}
},
"node_modules/which/node_modules/isexe": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some unrelated changes here. Could you please remove these?

@ghost
Copy link

ghost commented Jan 23, 2024

Thank you for your work, this is now resolved. Closing in favor of #267

@ghost ghost closed this Jan 23, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants