Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant trigger types from workflow #208

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Remove redundant trigger types from workflow #208

merged 2 commits into from
Jan 15, 2024

Conversation

rdhar
Copy link
Contributor

@rdhar rdhar commented Nov 3, 2023

Description

Going by documentation, "By default, a workflow only runs when a pull_request event's activity type is opened, synchronize, or reopened".

As a result, there's no need to redefine those types explicitly again and the line can be safely removed for the exact same behaviour. This suggestion can be applied directly for commit.

Motivation and Context

This change only serves to prevent over-definition since the default/standard behaviour is the expected one in this case. All about getting more for less!

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@Yantrio Yantrio merged commit d7f62c1 into opentofu:main Jan 15, 2024
1 of 2 checks passed
@rdhar rdhar deleted the patch-1 branch January 15, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants