Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent link color, refactor text content and doc card components #138

Merged
merged 16 commits into from
Sep 19, 2023

Conversation

damianstasik
Copy link
Collaborator

@damianstasik damianstasik commented Sep 19, 2023

Closes #130

This PR does a few things:

  • Makes sure all links have consistent look on hover (they should not use default theme's link color)
    • The exception to this rule are admonitions (always lightest gray in dark mode, and darkest gray in light mode)
    • And active navbar & TOC items, they just get an underline.
  • Cleans up text content to use the same TextContent component, now docs, blog and manifesto share the same styles.
  • Makes longer admonitions a bit more readable by increasing text contrast, the space between type and content and adding consistent line height to content.
  • Fixes a few times we had links wrapping headings, the correct syntax is the other way around.
  • Refactors the doc card component to use tailwind for better styling of the hover state. I just reused the styles from paginator nav links.

@damianstasik damianstasik changed the title [WIP] Use consistent link color Use consistent link color, refactor text content and doc card components Sep 19, 2023
@damianstasik damianstasik requested a review from Roma36 September 19, 2023 13:59
@damianstasik damianstasik marked this pull request as ready for review September 19, 2023 13:59
@damianstasik damianstasik merged commit 1e0cb74 into main Sep 19, 2023
@damianstasik damianstasik deleted the use-consistent-link-color branch September 19, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use brand color for links on hover
2 participants