Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add functionality to share faq item #112

Merged
merged 13 commits into from
Sep 19, 2023
Merged

add functionality to share faq item #112

merged 13 commits into from
Sep 19, 2023

Conversation

jakubabrzy
Copy link
Collaborator

In this PR click on the item add a hash to the link, after sharing the link the single faq item is open

closes #37

@damianstasik
Copy link
Collaborator

Thanks for taking care of this one!

Two things I see that may need an iteration are:

  1. This should only work on the FAQ page, but it works on homepage too.
  2. I don't know what we are going to put as questions, so maybe we could simplify the hash we store in the url.

src/components/Accordion/Item.tsx Outdated Show resolved Hide resolved
src/components/Accordion/Item.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@damianstasik damianstasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great! We just need to sync FAQ changes, either merge finalized FAQ and update this PR or other way around.

@Roma36
Copy link
Collaborator

Roma36 commented Sep 19, 2023

Works great!

@jakubabrzy jakubabrzy merged commit 5c78807 into main Sep 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make FAQ items shareable
3 participants