Use PNG logos in supporters list #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's all good except the Gruntwork logo, it's way too big |
|
I think I'll go with PNGs, I can make them smaller than 3kb, especially the one from Gruntwork which is 30kb as SVG. |
damianstasik
changed the title
damianstasik
force-pushed
the
use-svg-logos
branch
from
aba8489 to
23e85bd
Compare
|
Do we need any legal approvement to use those logos from those companies side? |
|
@jakubabrzy no need, all is good when it comes to the logos, the issue is with this PR, might be not needed so I'm converting it to a draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89
I took logos from official websites, made sure the colors match branding in both light and dark mode.