Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package name #3

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Update package name #3

merged 2 commits into from
Dec 25, 2024

Conversation

Evi1Pumpkin
Copy link
Collaborator

No description provided.

Copy link
Member

@Gogotchuri Gogotchuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, consistent changes of import paths.
I've added a comment regarding TODO, which would reference non-existent issue.

@@ -52,7 +52,7 @@ func checkBlock() *schema.BlockSchema {
func scopedDataBlock() *schema.BlockSchema {
bs := &schema.BlockSchema{
// TODO: Address: &schema.BlockAddrSchema{},
// See https://github.com/hashicorp/terraform-schema/issues/234
// See https://github.com/opentofu/opentofu-schema/issues/234
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This url doesn't exist, separate repo, separate issues.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! fixed that bf10a57

Signed-off-by: Ronny Orot <[email protected]>
@Evi1Pumpkin Evi1Pumpkin merged commit 99f895a into main Dec 25, 2024
4 checks passed
@Evi1Pumpkin Evi1Pumpkin deleted the update-package-name branch December 25, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants