Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize connection with proxy #16

Closed
wants to merge 1 commit into from

Conversation

odisk777
Copy link

@odisk777 odisk777 commented May 13, 2024

Description

I want to add this proxy function to optimize the client to server connection.

What is the use of this?
this helps players who have a bad connection or who are far away from the area where they want to connect. or also when you are far away from the server.
there are 5 proxy options, the client will look for the best connection you have and will balance with the others to deliver the best data packet to the user.

it is advisable to have several proxies from different places not all from one place because it would be in vain to put 5 ip from the same location.

if you want to disable the option just put “ --” in the proxy box to disable it.

checkbox

5 different connections
different latencies.

optimize connection

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version: canary
  • Client: OTCV8
  • Operating System: Windows 10 & 7

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

odisk777 added a commit to odisk777/otcv8 that referenced this pull request May 13, 2024
odisk777 added a commit to odisk777/otcv8 that referenced this pull request May 13, 2024
@majestyotbr majestyotbr changed the title Proxy optimizate connection ! feat: optimize connection with proxy Jun 2, 2024
@majestyotbr
Copy link
Contributor

You made changes that affects the default configs, can you change the file only with the proxy settings? Thanks.

@majestyotbr
Copy link
Contributor

Incomplete pull request, not working.

@majestyotbr majestyotbr closed this Jun 3, 2024
@odisk777
Copy link
Author

odisk777 commented Jun 3, 2024

You made changes that affects the default configs, can you change the file only with the proxy settings? Thanks.

the file can work with proxy or without proxy just by setting --local proxyList = { you can disable the proxy on the client.
if you have any problem you can report it to me to know what are the causes.

@majestyotbr
Copy link
Contributor

You made changes that affects the default configs, can you change the file only with the proxy settings? Thanks.

the file can work with proxy or without proxy just by setting --local proxyList = { you can disable the proxy on the client. if you have any problem you can report it to me to know what are the causes.

Check the lua and otui files you edited for proxy settings, make it compatible with the default settings of the client of the repository.

odisk777 added a commit to odisk777/otcv8 that referenced this pull request Jun 4, 2024
@odisk777
Copy link
Author

odisk777 commented Jun 4, 2024

You made changes that affects the default configs, can you change the file only with the proxy settings? Thanks.

the file can work with proxy or without proxy just by setting --local proxyList = { you can disable the proxy on the client. if you have any problem you can report it to me to know what are the causes.

Check the lua and otui files you edited for proxy settings, make it compatible with the default settings of the client of the repository.

here i sent a new repository made from 0 with the fixes i was testing and i didn't have any problem. if you don't have proxies and want to see if it works you can put your same ip with a wrong port and in the resource monitor. selecting otclient you will see many failed connection attempts to your ip.

@majestyotbr
Copy link
Contributor

You made changes that affects the default configs, can you change the file only with the proxy settings? Thanks.

the file can work with proxy or without proxy just by setting --local proxyList = { you can disable the proxy on the client. if you have any problem you can report it to me to know what are the causes.

Check the lua and otui files you edited for proxy settings, make it compatible with the default settings of the client of the repository.

here i sent a new repository made from 0 with the fixes i was testing and i didn't have any problem. if you don't have proxies and want to see if it works you can put your same ip with a wrong port and in the resource monitor. selecting otclient you will see many failed connection attempts to your ip.

First you need to learn how to do a pull request and send the changes with only one branch.

@odisk777
Copy link
Author

odisk777 commented Jun 4, 2024

First you need to learn how to do a pull request and send the changes with only one branch.

when I did it only via web on desktop you just select it and it is done.

odisk777 added a commit to odisk777/otcv8 that referenced this pull request Jun 5, 2024
error sumit commit two interface
@majestyotbr
Copy link
Contributor

First you need to learn how to do a pull request and send the changes with only one branch.

when I did it only via web on desktop you just select it and it is done.

I'm not going to find your changes. If you want to contribute, you should do it correctly.

@odisk777
Copy link
Author

odisk777 commented Jun 5, 2024

First you need to learn how to do a pull request and send the changes with only one branch.

when I did it only via web on desktop you just select it and it is done.

I'm not going to find your changes. If you want to contribute, you should do it correctly.

What is the problem with the contribution if everything is ok? if you don't open the push request I can't detect what is the problem with a new repository.

@majestyotbr
Copy link
Contributor

First you need to learn how to do a pull request and send the changes with only one branch.

when I did it only via web on desktop you just select it and it is done.

I'm not going to find your changes. If you want to contribute, you should do it correctly.

What is the problem with the contribution if everything is ok? if you don't open the push request I can't detect what is the problem with a new repository.

Everything is not ok, you didn't commited all the files to the same branch of the pull request. I already answered for you to check the lua and otui files.

@odisk777
Copy link
Author

odisk777 commented Jun 5, 2024

First you need to learn how to do a pull request and send the changes with only one branch.

when I did it only via web on desktop you just select it and it is done.

I'm not going to find your changes. If you want to contribute, you should do it correctly.

What is the problem with the contribution if everything is ok? if you don't open the push request I can't detect what is the problem with a new repository.

Everything is not ok, you didn't commited all the files to the same branch of the pull request. I already answered for you to check the lua and otui files.

I will delete this branch and when I have time I will upload this push request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants