Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added an option to leave miniwindows the same as the official client #14

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

brunoofgod
Copy link
Contributor

Description

Added an option to leave miniwidows the same as the official client, limiting the fixed space within the panels
image
image

When activated, the behavior will be the same as the official client. Placing the miniwindow in a panel
image

Behaviour

Actual

If you drag a miniwindow it has a unique behavior, always staying where it is dropped

Expected

With the change, the otclient starts to have an additional behavior, and may have the same characteristics as the official client.

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@majestyotbr majestyotbr changed the title Added an option to leave miniwidows the same as the official client, … feat: added an option to leave miniwindows the same as the official client Jun 2, 2024
@majestyotbr majestyotbr merged commit 386b230 into opentibiabr:main Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants