Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: api client account creator #33

Merged

Conversation

elsongabriel
Copy link
Collaborator

@elsongabriel elsongabriel commented Oct 11, 2023

Description

Created script to create account and character by the client.
First, you need to change your accountCreationClientServices client's config or update config.ini like this:
from
accountCreationClientServices=https://www.tibia.com/clientservices/accountcreationclientservices.php
to
accountCreationClientServices=http://YOURSITE/clientcreateaccount.php

image

OBS: Creating characters from this windows, is only available to create in "rook", creating with vocation is not permitted.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Test Configuration:

  • MyAAC Version: (latest: 0.8.12)
  • Browser: Chrome
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I followed project rules, best practices and code indentation
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@luancolombo
Copy link
Contributor

Bom dia, deixando aqui meu feedback..a API ta funcionando perfeitamente fiz varios testes locais, porém unico problema e que quando voce clica em Start Playing não acontece nada, ou seja voce nao tem nenhuma resposta que a conta foi criada, entao voce clica de novo e ai sim aparece um erro que o email e invalido(isso acontece pq a conta foi criada ja porem nao tivemos a resposta do servidor). Mas fora isso ta top.

@Kasllow
Copy link

Kasllow commented Nov 1, 2023

I tested mine, the only thing is that it doesn't create the char ;/

@majestyotbr majestyotbr marked this pull request as draft November 19, 2023 22:46
@elsongabriel
Copy link
Collaborator Author

I tested mine, the only thing is that it doesn't create the char ;/

I've tested too. In local doesn't create char. but in VPS (production) it does.
Can you check too ? I will review the code again.

@QuebradaZN
Copy link

I've tested too. In local doesn't create char. but in VPS (production) it does.
Can you check too ? I will review the code again.

I ran tests on VPS (Prod) and indeed char cannot be created!

Copy link

github-actions bot commented Jan 2, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jan 2, 2024
@github-actions github-actions bot removed the Stale label Feb 10, 2024
@elsongabriel elsongabriel closed this by deleting the head repository Feb 28, 2024
@elsongabriel elsongabriel reopened this Mar 1, 2024
Copy link

github-actions bot commented Apr 5, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Apr 5, 2024
@elsongabriel elsongabriel force-pushed the feature/create-account-from-client branch from 896e408 to 7d93e91 Compare May 28, 2024 19:07
@elsongabriel elsongabriel force-pushed the feature/create-account-from-client branch from 7d93e91 to 6dd4aa1 Compare May 28, 2024 19:11
@github-actions github-actions bot removed the Stale label May 29, 2024
…ccount_premium_coins' to 'account_welcome_coins' and fix their usages. changed main coin to 'coins_transferable'.
@elsongabriel elsongabriel force-pushed the feature/create-account-from-client branch from 4555f22 to c1e0790 Compare May 29, 2024 12:53
@elsongabriel elsongabriel marked this pull request as ready for review May 29, 2024 13:46
@elsongabriel elsongabriel requested a review from majestyotbr May 31, 2024 14:12
@elsongabriel elsongabriel merged commit 893702a into opentibiabr:main Jun 4, 2024
7 checks passed
@elsongabriel elsongabriel deleted the feature/create-account-from-client branch June 4, 2024 16:41
lucas-caminha pushed a commit to lucas-caminha/myaac that referenced this pull request Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants