Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/run set pending children on epoch #1171

Open
wants to merge 3 commits into
base: devnet-ready
Choose a base branch
from

Conversation

camfairchild
Copy link
Contributor

Description

Fixes regression with scheduling the pending children. This should run in the epoch, but only after the coinbase payout.
Also adds a test for this behaviour.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@camfairchild camfairchild requested a review from unconst as a code owner January 20, 2025 14:30
@camfairchild camfairchild changed the base branch from main to devnet-ready January 20, 2025 14:30
@camfairchild camfairchild added the no-spec-version-bump PR does not contain changes that requires bumping the spec version label Jan 20, 2025
@sam0x17 sam0x17 added skip-cargo-audit This PR fails cargo audit but needs to be merged anyway and removed no-spec-version-bump PR does not contain changes that requires bumping the spec version labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants