-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make docker image builds trigger on key branches + ability to manually trigger #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam0x17
added
skip-cargo-audit
This PR fails cargo audit but needs to be merged anyway
and removed
skip-cargo-audit
This PR fails cargo audit but needs to be merged anyway
labels
Jan 17, 2025
sam0x17
added
the
skip-cargo-audit
This PR fails cargo audit but needs to be merged anyway
label
Jan 17, 2025
keithtensor
reviewed
Jan 21, 2025
branches: | ||
- devnet-ready | ||
- devnet | ||
- testnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not testing on main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, for main people should use the releases, which also get deployed by this automatically
sam0x17
added
the
no-spec-version-bump
PR does not contain changes that requires bumping the spec version
label
Jan 21, 2025
sam0x17
changed the title
make docker image builds trigger on key branches
make docker image builds trigger on key branches + ability to manually trigger
Jan 21, 2025
unconst
approved these changes
Jan 21, 2025
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blue team
defensive programming, CI, etc
no-spec-version-bump
PR does not contain changes that requires bumping the spec version
skip-cargo-audit
This PR fails cargo audit but needs to be merged anyway
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so the current state of
devnet-ready
,devnet
, andtestnet
is continuously deployed to docker hub using the branch names as the tag name.It also makes it so we can manually trigger branches or tags to deploy to docker hub based on a workflow dispatch. Currently it does not allow for deploying a branch/tag with a different branch/tag name in docker hub, however this could be added if it is desired later.