Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chainspecs to a dedicated directory #1025

Merged
merged 7 commits into from
Nov 29, 2024
Merged

Conversation

ales-otf
Copy link
Contributor

@ales-otf ales-otf commented Nov 27, 2024

Description

This PR moves chain spec files into a dedicated directory chainspecs.

It also fixes build_all_chainspecs.sh script by preventing genesis rewrites in the plain specs. And extends it to build devnet specs as well.

The bootnode address for testnet is changed to /dns/bootnode.test.chain.opentensor.ai/tcp/30333/p2p/12D3KooWEKUzXbgbJzCnAGcCLFwcEbDBp9ixa3aVVgJ5smiX1fSJ (requested by prop_physics)

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

Warning

As the script previously didn't handle keeping of genesis for plain specs, the plain specs genesis for finney and testfinney don't match the one in the raw specs.

@ales-otf ales-otf marked this pull request as ready for review November 27, 2024 17:15
@ales-otf ales-otf requested a review from unconst as a code owner November 27, 2024 17:15
gztensor
gztensor previously approved these changes Nov 27, 2024
@open-junius
Copy link
Contributor

looks good to me. @rajkaramchedu the spec file folder is changed. we need update the doc https://docs.bittensor.com/subtensor-nodes.

@rajkaramchedu
Copy link
Contributor

I haven't looked at the code of this scripts/localnet.sh in detail, but I assume this script is not impacted with this PR? cc @galina-opentensor

@ales-otf
Copy link
Contributor Author

@rajkaramchedu

I haven't looked at the code of this scripts/localnet.sh in detail, but I assume this script is not impacted with this PR? cc @galina-opentensor

It's not. scripts/localnet.sh first builds the chainspec file inside scripts/specs and then uses this file (actually, for localnet we can omit doing it and just specify the chainspec name).

@sam0x17 sam0x17 merged commit 9da2947 into devnet-ready Nov 29, 2024
rajkaramchedu added a commit to opentensor/developer-docs that referenced this pull request Nov 29, 2024
Updating this doc as per the change made in opentensor/subtensor#1025
@ales-otf ales-otf deleted the chore/chainspecs-folder branch December 2, 2024 16:24
rajkaramchedu added a commit to opentensor/developer-docs that referenced this pull request Dec 17, 2024
Updating this doc as per the change made in opentensor/subtensor#1025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants