Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hard coded return_per_1000 #1015

Open
wants to merge 12 commits into
base: devnet-ready
Choose a base branch
from
Open

Conversation

open-junius
Copy link
Contributor

Description

To fix the issue #992

Related Issue(s)

  • Closes #[992]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius requested a review from unconst as a code owner November 25, 2024 14:25
@open-junius open-junius self-assigned this Nov 25, 2024
@open-junius open-junius requested a review from a team November 25, 2024 14:45
sam0x17
sam0x17 previously approved these changes Nov 25, 2024
@sam0x17 sam0x17 requested a review from a team November 25, 2024 16:32
Copy link
Contributor

@cuteolaf cuteolaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
what about to add a test?

@open-junius
Copy link
Contributor Author

looks good to me. what about to add a test?
will check how to test rpc function

@@ -64,7 +64,8 @@ impl<T: Config> Pallet<T> {

let return_per_1000: U64F64 = if total_stake > U64F64::from_num(0) {
emissions_per_day
.saturating_mul(U64F64::from_num(0.82))
.saturating_mul(U64F64::from_num(u16::MAX.saturating_sub(take.0)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use .into() here to be more idiomatic?

@gztensor gztensor added no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RAO] Calculation of the return_per_1000 in DelegateInfo RPC is incorrect
4 participants