Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAO] Calculation of the return_per_1000 in DelegateInfo RPC is incorrect #992

Open
gztensor opened this issue Nov 18, 2024 · 1 comment · May be fixed by #1015
Open

[RAO] Calculation of the return_per_1000 in DelegateInfo RPC is incorrect #992

gztensor opened this issue Nov 18, 2024 · 1 comment · May be fixed by #1015
Assignees
@open-junius

Comments

@gztensor
Copy link
Contributor

gztensor commented Nov 18, 2024 •
edited
Loading

The return_per_1000 in DelegateInfo RPC has hardcoded parameter

The 18% delegate take is hardcoded as 1 - 18% = 0.82 in get_delegate_by_existing_account. If it changes, the DelegateInfo::return_per_1000 will be inaccurate. Change it to read the delegate take from Delegates state map.
@gztensor gztensor added good first issue Good for newcomers and removed good first issue Good for newcomers labels Nov 18, 2024
@gztensor gztensor changed the title The return_per_1000 in DelegateInfo RPC has hardcoded parameter Calculation of the return_per_1000 in DelegateInfo RPC is incorrect Nov 18, 2024
@gztensor gztensor changed the title Calculation of the return_per_1000 in DelegateInfo RPC is incorrect [RAO] Calculation of the return_per_1000 in DelegateInfo RPC is incorrect Nov 18, 2024
@hey-michal
Copy link

just adding the comment for visibility since Cerebrum depends on this.

@open-junius open-junius self-assigned this Nov 22, 2024
@open-junius open-junius linked a pull request Nov 25, 2024 that will close this issue
Open
13 tasks
@gztensor gztensor linked a pull request Dec 5, 2024 that will close this issue
fix hard coded return_per_1000 #1015
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@open-junius open-junius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix hard coded return_per_1000 opentensor/subtensor
3 participants
@hey-michal @open-junius @gztensor