-
Notifications
You must be signed in to change notification settings - Fork 171
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'devnet-ready' into sam-test-coverage
- Loading branch information
Showing
41 changed files
with
758 additions
and
468 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,28 @@ | ||
| #!/bin/bash | ||
| set -ex | ||
| cd support/macros | ||
| cargo publish --token $1 | ||
| cargo publish $1 | ||
| cd ../.. | ||
| cd pallets/commitments | ||
| cargo publish --token $1 | ||
| cargo publish $1 | ||
| cd .. | ||
| cd collective | ||
| cargo publish --token $1 | ||
| cargo publish $1 | ||
| cd .. | ||
| cd registry | ||
| cargo publish --token $1 | ||
| cargo publish $1 | ||
| cd .. | ||
| cd subtensor | ||
| cargo publish --token $1 | ||
| cargo publish $1 | ||
| cd runtime-api | ||
| cargo publish --token $1 | ||
| cargo publish $1 | ||
| cd ../.. | ||
| cd admin-utils | ||
| cargo publish --token $1 | ||
| cargo publish $1 | ||
| cd ../.. | ||
| cd runtime | ||
| cargo publish --token $1 | ||
| cargo publish $1 | ||
| cd .. | ||
| cd node | ||
| cargo publish --token $1 | ||
| cargo publish $1 | ||
| echo "published successfully." |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| use super::*; | ||
| use syn::{visit::Visit, ExprMethodCall, File, Ident}; | ||
|
|
||
| pub struct ForbidAsPrimitiveConversion; | ||
|
|
||
| impl Lint for ForbidAsPrimitiveConversion { | ||
| fn lint(source: &File) -> Result { | ||
| let mut visitor = AsPrimitiveVisitor::default(); | ||
|
|
||
| visitor.visit_file(source); | ||
|
|
||
| if !visitor.errors.is_empty() { | ||
| return Err(visitor.errors); | ||
| } | ||
|
|
||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| #[derive(Default)] | ||
| struct AsPrimitiveVisitor { | ||
| errors: Vec<syn::Error>, | ||
| } | ||
|
|
||
| impl<'ast> Visit<'ast> for AsPrimitiveVisitor { | ||
| fn visit_expr_method_call(&mut self, node: &'ast ExprMethodCall) { | ||
| if is_as_primitive(&node.method) { | ||
| self.errors.push(syn::Error::new( | ||
| node.method.span(), | ||
| "Using 'as_*()' methods is banned to avoid accidental panics. Use `try_into()` instead.", | ||
| )); | ||
| } | ||
|
|
||
| syn::visit::visit_expr_method_call(self, node); | ||
| } | ||
| } | ||
|
|
||
| fn is_as_primitive(ident: &Ident) -> bool { | ||
| matches!( | ||
| ident.to_string().as_str(), | ||
| "as_u32" | "as_u64" | "as_u128" | "as_usize" | ||
| ) | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
|
|
||
| fn lint(input: &str) -> Result { | ||
| let expr: ExprMethodCall = syn::parse_str(input).expect("should only use on a method call"); | ||
| let mut visitor = AsPrimitiveVisitor::default(); | ||
| visitor.visit_expr_method_call(&expr); | ||
| if !visitor.errors.is_empty() { | ||
| return Err(visitor.errors); | ||
| } | ||
| Ok(()) | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_as_primitives() { | ||
| let input = r#"x.as_u32()"#; | ||
| assert!(lint(input).is_err()); | ||
| let input = r#"x.as_u64()"#; | ||
| assert!(lint(input).is_err()); | ||
| let input = r#"x.as_u128()"#; | ||
| assert!(lint(input).is_err()); | ||
| let input = r#"x.as_usize()"#; | ||
| assert!(lint(input).is_err()); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_non_as_primitives() { | ||
| let input = r#"x.as_ref()"#; | ||
| assert!(lint(input).is_ok()); | ||
| let input = r#"x.as_slice()"#; | ||
| assert!(lint(input).is_ok()); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.