-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a bug in the get_subnets function #2240
Open
niljub
wants to merge
21
commits into
opentensor:staging
Choose a base branch
from
niljub:hotfix/7.3.0/get-subnets-fix/niljub
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8022866
Applies fix and assertions
ibraheem-opentensor 96badeb
Debug commit
ibraheem-opentensor af76ca3
Fixed a bug in the get_subnets function
niljub 40512c8
Dummy commit
ibraheem-opentensor bf00b93
Merge branch 'staging' into hotfix/7.3.0/get-subnets-fix/niljub
niljub 89d0bd3
Merge branch 'staging' into hotfix/7.3.0/get-subnets-fix/niljub
niljub 1934ad3
Changed the test to test 500 subnets
niljub 65aa008
Merge branch 'hotfix/7.3.0/get-subnets-fix/niljub' of https://github.…
niljub ad1c35a
Fixed a bug in the get_subnets function (again)
niljub 0d236db
Child Hotkeys netuid Refactor
4379c59
CHK Test
4b046c3
u16 float limit
dfe3cfd
Merge branch 'staging' into feat/opendansor/chk
f0e09f2
Merge pull request #2276 from opentensor/feat/opendansor/chk
0d7361b
Merge branch 'staging' into hotfix/7.3.0/get-subnets-fix/niljub
distributedstatemachine f7345a6
Merge branch 'staging' into fix/metagraph-load-and-assertions
ibraheem-opentensor d438b0f
Merge pull request #2235 from opentensor/fix/metagraph-load-and-asser…
ibraheem-opentensor 6a7b2ca
Add reconnection logic + tests
roman-opentensor 5fcdcfd
Merge pull request #2280 from opentensor/feat/roman/add-subtensor-rec…
roman-opentensor c7b4739
removed exit sys call for ConnectionRefusedError in _get_substrate (#…
garrett-opentensor 8cdf462
Merge branch 'staging' into hotfix/7.3.0/get-subnets-fix/niljub
niljub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this test for length > 100?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right—I missed a zero. I've added it and pushed a changed version along with the updated test, but the test still doesn't catch the issue. I also updated get_subnets again and verified it by running your snippet.