Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CI): suppress generated files in PR diffs #389

Merged
merged 21 commits into from
Mar 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
70e3af8
suppress generated code via .gitattributes
jakedoublev Mar 13, 2024
9af4049
add generate CI action to rebuild suppressed files
jakedoublev Mar 13, 2024
32c6a72
add toolcheck
jakedoublev Mar 13, 2024
10ef11d
bring in proto dependencies
jakedoublev Mar 13, 2024
901d2b9
pin to golangci-lint 1.55 in generate workflow
jakedoublev Mar 13, 2024
4137e1e
improve logs and remove toolcheck with dependencies installed
jakedoublev Mar 13, 2024
04a04a3
test alteration of generated file
jakedoublev Mar 13, 2024
d2ccb4f
remove generated grpc index.html docs
jakedoublev Mar 13, 2024
7dbb047
remove more docs to test suppression
jakedoublev Mar 13, 2024
d111397
remove comments from gencode to test suppression
jakedoublev Mar 13, 2024
32ab413
push generation after commit and improve logs
jakedoublev Mar 13, 2024
f164d48
add branch name to generate workflow
jakedoublev Mar 13, 2024
45e4693
add dummy proto to visualize suppressed diff
jakedoublev Mar 13, 2024
d861dc2
.gitattributes update
jakedoublev Mar 13, 2024
5ba5cab
fix java generated code filepath
jakedoublev Mar 13, 2024
447b7c6
denote the TODO to use groups instead of individuals in .gitattribute…
jakedoublev Mar 13, 2024
f14934c
remove generate workflow in favor of using a github pages automation …
jakedoublev Mar 13, 2024
4d55056
remove dummy proto
jakedoublev Mar 13, 2024
ea8d8df
Merge branch 'main' into feature/suppress-generated
jakedoublev Mar 13, 2024
97b40d3
make sure generation from protos cleans docs and regenerates
jakedoublev Mar 13, 2024
620f819
clean codeowners
jakedoublev Mar 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
protocol/go/** linguist-generated=true
sdkjava/src/main/java/** linguist-generated=true
docs/grpc/** linguist-generated=true
docs/openapi/** linguist-generated=true
6 changes: 5 additions & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# CODEOWNERS

* @opentdf/developers
* @opentdf/developers

# Suppresses generated files in diffs
# TODO: change these to known groups instead of individuals
.gitattributes @biscoe916 @jrschumacher @strantalis @ttschampel
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ go-lint:
for m in $(MODS); do (cd $$m && golangci-lint run $(LINT_OPTIONS) --path-prefix=$$m) || exit 1; done

proto-generate:
rm -rf sdkjava/src protocol/go/[a-fh-z]*
rm -rf sdkjava/src protocol/go/[a-fh-z]* docs/grpc docs/openapi
buf generate services
buf generate services --template buf.gen.grpc.docs.yaml
buf generate services --exclude-path $(EXCLUDE_JAVA) --template buf.gen.java.yaml
Expand Down
241 changes: 0 additions & 241 deletions docs/openapi/access/access.swagger.json

This file was deleted.

Loading
Loading