Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): we should update the entire list of keys rather than contanate them #1837

Merged
merged 3 commits into from
Jan 7, 2025
Merged

chore(ci): we should update the entire list of keys rather than contanate them #1837

merged 3 commits into from
Jan 7, 2025
+1 −1

Conversation

mkleene
Copy link
Contributor

@mkleene mkleene commented Jan 7, 2025 •
edited
Loading

Proposed Changes

  • Doing things this way causes tests to fail due to specific keys being required

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@mkleene mkleene marked this pull request as ready for review January 7, 2025 17:39
@mkleene mkleene requested a review from a team as a code owner January 7, 2025 17:39
@mkleene mkleene enabled auto-merge January 7, 2025 17:42
sujankota
sujankota previously approved these changes Jan 7, 2025
View reviewed changes
@mkleene mkleene disabled auto-merge January 7, 2025 17:45
@mkleene mkleene enabled auto-merge January 7, 2025 18:17
@strantalis strantalis disabled auto-merge January 7, 2025 19:02
@strantalis strantalis changed the title fix(sdk): we should update the entire list of keys rather than contanate them chore(ci): we should update the entire list of keys rather than contanate them Jan 7, 2025
@strantalis strantalis merged commit 553d8a7 into main Jan 7, 2025
21 of 23 checks passed
@strantalis strantalis deleted the mkleene-patch-1 branch January 7, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strantalis strantalis strantalis approved these changes

@sujankota sujankota sujankota left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkleene @sujankota @strantalis