Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): GetDecisions should handle empty string and non-existent attributes #1832

Merged
merged 3 commits into from
Jan 3, 2025
Merged

fix(core): GetDecisions should handle empty string and non-existent attributes #1832

merged 3 commits into from
Jan 3, 2025

Conversation

elizabethhealy
Copy link
Member

Proposed Changes

  • if a resouce attribute fqn list only has "", DENY
  • if a resource attribute fqn list has "" and other attributes, ignore the ""
  • if a resource attribute fqn list has a non existent attribute, DENY

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@elizabethhealy elizabethhealy marked this pull request as ready for review December 20, 2024 20:19
@elizabethhealy elizabethhealy requested a review from a team as a code owner December 20, 2024 20:19
jentfoo
jentfoo reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@jentfoo jentfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but I think the added complexity in the commented for loop can be removed.

service/authorization/authorization.go Show resolved Hide resolved
@elizabethhealy elizabethhealy added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit dc89678 Jan 3, 2025
22 checks passed
@elizabethhealy elizabethhealy deleted the dsp-397-getdecision-ra-fqn-handling branch January 3, 2025 15:55
@opentdf-automation opentdf-automation bot mentioned this pull request Jan 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pflynn-virtru pflynn-virtru pflynn-virtru approved these changes

@jentfoo jentfoo jentfoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elizabethhealy @jentfoo @pflynn-virtru