Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): properly chain grpc-gateway middleware order #1820

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(core): properly chain grpc-gateway middleware order #1820

merged 1 commit into from
Dec 11, 2024

Conversation

strantalis
Copy link
Member

Proposed Changes

Fixes the grpc-gateway middleware chaining order. Handling of a cors pre-flight call before moving onto auth middleware.

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@strantalis strantalis requested a review from a team as a code owner December 11, 2024 17:11
@strantalis strantalis added this pull request to the merge queue Dec 11, 2024
Merged via the queue into opentdf:main with commit 5b9f054 Dec 11, 2024
22 checks passed
@strantalis strantalis deleted the cors-issue branch December 11, 2024 17:38
@opentdf-automation opentdf-automation bot mentioned this pull request Dec 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2024
@opentdf-automation
chore(main): release service 0.4.34 (#1821)
7d55a90 
🤖 I have created a release *beep* *boop*
---


##
[0.4.34](service/v0.4.33...service/v0.4.34)
(2024-12-11)


### Bug Fixes

* **core:** properly chain grpc-gateway middleware order
([#1820](#1820))
([5b9f054](5b9f054))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkleene mkleene mkleene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strantalis @mkleene