Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Handle multiple modes including entityresolution mode #1816

Merged
merged 13 commits into from
Dec 6, 2024
Merged

fix(core): Handle multiple modes including entityresolution mode #1816

merged 13 commits into from
Dec 6, 2024

Conversation

elizabethhealy
Copy link
Member

Proposed Changes

  • handle sdk_config error throwing when mulltiple modes are present
  • need to sdk config when running in kas or core without ers

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@elizabethhealy elizabethhealy marked this pull request as ready for review December 5, 2024 23:01
@elizabethhealy elizabethhealy requested a review from a team as a code owner December 5, 2024 23:01
strantalis
strantalis previously approved these changes Dec 5, 2024
View reviewed changes
@strantalis strantalis dismissed their stale review December 5, 2024 23:48

test failing

@elizabethhealy elizabethhealy added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 32d6938 Dec 6, 2024
22 checks passed
@elizabethhealy elizabethhealy deleted the fix-ers-mode-multiple-modes branch December 6, 2024 21:00
@opentdf-automation opentdf-automation bot mentioned this pull request Dec 4, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 6, 2024
@opentdf-automation
chore(main): release service 0.4.33 (#1814)
260d732 
🤖 I have created a release *beep* *boop*
---


##
[0.4.33](service/v0.4.32...service/v0.4.33)
(2024-12-06)


### Bug Fixes

* **core:** Allow more users to rewrap
([#1813](#1813))
([4d47475](4d47475))
* **core:** Handle multiple modes including entityresolution mode
([#1816](#1816))
([32d6938](32d6938))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strantalis strantalis strantalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elizabethhealy @strantalis