Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Allow more users to rewrap #1813

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix(core): Allow more users to rewrap #1813

merged 1 commit into from
Dec 4, 2024

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Dec 4, 2024 •
edited
Loading

Proposed Changes

  • Always add 'unknown' casbin role, not just to users who have no roles
  • Fixes bug where users with some realm roles, but not known ones, would not be able to rewrap

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@dmihalcik-virtru
fix(core): Allow more users to rewrap
1fa2a99 
- Always add 'unknown' casbin role, not just to users who have no roles
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner December 4, 2024 19:48
@dmihalcik-virtru dmihalcik-virtru added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 4d47475 Dec 4, 2024
23 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the feature/unknown-enforcers branch December 4, 2024 20:36
@opentdf-automation opentdf-automation bot mentioned this pull request Dec 4, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 6, 2024
@opentdf-automation
chore(main): release service 0.4.33 (#1814)
260d732 
🤖 I have created a release *beep* *boop*
---


##
[0.4.33](service/v0.4.32...service/v0.4.33)
(2024-12-06)


### Bug Fixes

* **core:** Allow more users to rewrap
([#1813](#1813))
([4d47475](4d47475))
* **core:** Handle multiple modes including entityresolution mode
([#1816](#1816))
([32d6938](32d6938))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pflynn-virtru pflynn-virtru pflynn-virtru approved these changes

@elizabethhealy elizabethhealy elizabethhealy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmihalcik-virtru @elizabethhealy @pflynn-virtru