Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): DSP-230 basic config service implementation #1759

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ryanulit
Copy link
Contributor

@ryanulit ryanulit commented Nov 14, 2024

Proposed Changes

This is the initial POC of the Config Service, with all code located in the platform repo for the sole purpose of ease of implementation. There are still ongoing discussions about having the code live in DSP with some sort of shim/plugin functionality provided by the platform to enable loading the custom PEP/service configs.

Goals of the Config Service:

  • Use Protobuf definitions with custom options to define config fields and their metadata in a single file
  • Config protobuf defines the schema for configuration fields
  • Internal PEP/Service uses the Config protobuf definition to create their unique configurations
  • PEP/Service configs stored in a new schema of existing Postgres DB
  • Admin Web UI forms can be dynamically generated from Proto definitions
  • gRPC Service allows Admin to create/modify configs from Admin Web UI or CLI

Whimsical:

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant