-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tiktoken dependencies build error #4143
Conversation
Walkthrough此次更改在 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Webpack
participant WebAssembly
User->>Webpack: 开始构建
Webpack->>WebAssembly: 启用异步 WebAssembly
WebAssembly-->>Webpack: 准备好 WebAssembly 模块
Webpack-->>User: 完成构建
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
tools/cli-engine/configs/webpack.config.browser.js (1)
42-44
: 配置更改正确解决了构建问题此配置更改通过启用异步 WebAssembly 支持来解决 tiktoken 依赖的构建问题,这是一个恰当的解决方案。
建议在注释中添加更多上下文信息,说明这是为了解决 tiktoken 依赖的构建问题:
experiments: { - asyncWebAssembly: true, // 启用 WebAssembly 支持 + asyncWebAssembly: true, // 启用 WebAssembly 支持,用于解决 tiktoken 依赖的构建问题 },
Types
Background or solution
Changelog
修复 tiktoken 依赖的构建问题
Summary by CodeRabbit