Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support VSCode API: TaskPresentationOptions #4137

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

bk1012
Copy link
Member

@bk1012 bk1012 commented Oct 30, 2024

Types

  • 🎉 New Features

Background or solution

Support VSCode API: TaskPresentationOptions

Changelog

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.07%. Comparing base (926108b) to head (60feb5b).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
packages/task/src/browser/task-executor.ts 23.07% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4137      +/-   ##
==========================================
- Coverage   54.23%   54.07%   -0.16%     
==========================================
  Files        1598     1610      +12     
  Lines       97657    97805     +148     
  Branches    19984    20031      +47     
==========================================
- Hits        52961    52891      -70     
- Misses      37124    37312     +188     
- Partials     7572     7602      +30     
Flag Coverage Δ
jsdom 49.64% <23.07%> (-0.15%) ⬇️
node 15.57% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bk1012 bk1012 force-pushed the feat/support-TaskPresentationOptions branch from ea1f61b to 2d3192b Compare November 7, 2024 02:33
@Aaaaash Aaaaash changed the title WIP: feat: support VSCode API: TaskPresentationOptions feat: support VSCode API: TaskPresentationOptions Nov 15, 2024
@bk1012 bk1012 merged commit c03fe77 into main Nov 15, 2024
12 checks passed
@bk1012 bk1012 deleted the feat/support-TaskPresentationOptions branch November 15, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants